Repository navigation
Conversation
…ramps
- Add `SepaDepositInstructions` and `extractSepaDepositInstructions`, and
return `{ type: 'Sepa' }` from `NeoBankService.getDepositInstructions`
after the PIX and US bank rails.
- Reuse the SEPA extractor when labelling `depositRailsSummary.currency`.
- Require only the `sepa` rail for EUR in
`getMusdAutorampDepositRailReadiness`; the proxy falls back to a
first-party autoramp when `sepa_thirdparty` is not Active.
…tructions Carry the autoramp's `inbound_payment_reference` through as `paymentReference` on `SepaDepositInstructions` when MoonPay uses pay-by-reference, and omit it when the value is missing, null, or empty.
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
8 of 10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
EUR autoramps previously had no deposit instructions:
AutorampDepositInstructionsonly covered PIX and US bank rails, andNeoBankService.getDepositInstructionsignored the SEPA rail. Clients therefore had no way to show a EUR user how to fund the deposit.This adds a
Sepavariant end to end:SepaDepositInstructionsandextractSepaDepositInstructions, exported from the package, reading the IBAN and optional BIC, account holder, bank name, and bank address from the autoramp'sSEPAdeposit rail.NeoBankService.getDepositInstructionsnow falls back to the SEPA rail after the PIX and US bank rails and returns{ type: 'Sepa', ... }.depositRailsSummary.currency, so the summary and the instructions agree.getMusdAutorampDepositRailReadinessnow requires theseparail for EUR. It does not requiresepa_thirdparty, because neobank-proxy falls back to a first-party autoramp when that rail is not Active.inbound_payment_referenceaspaymentReferencewhen MoonPay uses pay-by-reference, and omit it when the value is absent,null, or empty.AutorampDepositInstructionsgaining a variant is breaking: exhaustive switches on itstypemust handleSepa.References
Checklist
Client PR: MetaMask/metamask-mobile#39383