Repository navigation
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
micaelae
force-pushed
the
swaps-refactor-before-money-acct
branch
from
November 10, 2026 08:04
f3f6fd5 to
9fd4045
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9fd4045. Configure here.
| }; | ||
|
|
||
| // Only EVM txs | ||
| /** |
There was a problem hiding this comment.
Nested bridge failures skip quote finalization
Medium Severity
Failed nested 7702/batch bridges are now routed through tradeUpdateHandler, but #onTransactionFailed still only treats isCrossChainTx(type) or hasNestedSwapTransactions as a trade. A batch tx with nested bridges therefore never calls reportFinalised. isAtomic7702BatchTx has the same gap, so history matching for nested-bridge batches is inconsistent with nested swaps.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 9fd4045. Configure here.
…act serialized SubmitStrategyParams
micaelae
force-pushed
the
swaps-refactor-before-money-acct
branch
from
November 10, 2026 17:43
9fd4045 to
0f61514
Compare
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Touches bridge submit/status lifecycle, history keys, and transaction confirmation side effects—regressions could affect polling, metrics, or activity list accuracy without breaking compile-time safety.
Overview
Pulls Accounts, Network, and Remote Feature Flags messenger access into shared helpers under
bridge-controller(getAccountByAddress,getNetworkClientByChainId,getFeatureFlags) and re-exports them so other packages (including bridge-status) can depend on one place instead of duplicating#getNetworkClientByChainIdor localaccounts.ts.Bridge Status Controller gets the larger behavioral refactor:
TransactionController:transactionStatusUpdatedhandling moves intotradeUpdateHandler/approvalUpdateHandlerwithresolveHistoryKeyForTxMeta, confirmation logic distinguishes bridge vs swap/nested txs more explicitly, and history rekeying no longer threads rawTransactionMeta—overrides come fromgetHistoryOverridesFromTxMetaand an updatedrekeyHistoryItemInState. Quote v1/v2 normalization is extracted tonormalizeQuoteResponses, and the Firefox-specificStartPollingForBridgeTxStatusArgsSerializedtype is removed in favor of a single args type.Submit strategies (EVM, batch, batch-sell) and tests are updated for the new history override shape; lint/tsc suppression counts are adjusted accordingly.
Reviewed by Cursor Bugbot for commit c326eb7. Bugbot is set up for automated code reviews on this repo. Configure here.