Repository navigation
[DO NOT MERGE] Notify SourceOfTruthWithBarrier on delete and deleteAll (#731) - #768
Open
binayshaw7777 wants to merge 2 commits into
Open
binayshaw7777 wants to merge 2 commits into
binayshaw7777 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #731
Description
When
store.clear(key)orstore.clear()was called,SourceOfTruthWithBarrier.delete()anddeleteAll()forwarded the call directly to the delegate without notifyingbarriers(MutableStateFlow<BarrierMsg>).As a result:
PersistentNonFlowingSourceOfTruth) never knew the data was deleted.barrier.flatMapLatestwas never re-evaluated, leaving stream collectors holding stale in-memory state and failing to trigger downstream network refetches.This PR ensures:
RefCountedResourceexposes active keys.SourceOfTruthWithBarrier.delete()anddeleteAll()acquire and transition barriers toBlocked, execute delegate deletion, and reopen withisDelete = trueand incremented versions.Type of Change
Test Plan
deleteNotifiesActiveReaderFlowinSourceOfTruthWithBarrierTests.ktconfirming that an active reader flow receives an emission whendelete(key)is invoked../gradlew :store:jvmTest.Checklist