Repository navigation
Conversation
shihaobai
added a commit
that referenced
this pull request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLM can emit
<tool_call>before</think>, causing reasoning extraction to hide tool calls or alter literal markers inside arguments. Route tool envelopes through the GLM reasoning detector intact, and use an argument-aware scanner for streaming and non-streaming tool parsing. Preserve literal strings and schema-directed argument values.Keep the request's thinking switch separate from the initial generation phase. Resolve the phase through the detector after rendering the prompt, then share it across reasoning parsing, string-stop matching and grammar activation. Flush buffered text before tool parsing when generation ends so truncated XML arguments do not leak into content.
Validation: