Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A failed compare-and-exchange in
add_boundedorsub_boundedcan permanently reduce the requested amount before the operation retries. If capacity changes again, a successful retry can leave usable capacity unclaimed. The add path feeds host, device, and diskreserve_uptooperations.Recalculate the bounded amount from the original request on every retry and publish the actual amount only after a successful exchange. Include
<algorithm>for thestd::mindependency; this overlaps the independent header fix in #236.Fixes #237.
Validation
clang-formatpassed for the changed C++ files andgit diff --checkpassed. No GPU workload, full project build, or reservation throughput benchmark was run.