[omar-d1]

Problem

routing_map() raises RuntimeError: object is not bound whenever it is called with no HTTP request in flight.

Both helpers this module adds to ir.http are classmethods, so neither has self.env, and both reach the endpoint registry through http.request.env:

@classmethod
def _endpoint_routing_rules(cls):
    e_registry = cls._endpoint_route_registry(http.request.env)

@classmethod
def _endpoint_route_last_version(cls):
    res = cls._get_routing_map_last_version(http.request.env)

The second one sits in the ormcache key of routing_map, so it runs before the wrapped body and the failure happens while computing the key.

How to reproduce

One line in odoo shell, on a database with endpoint_route_handler installed:

env['ir.http'].routing_map()

File ".../endpoint_route_handler/models/ir_http.py", line 48, in _endpoint_route_last_version
    res = cls._get_routing_map_last_version(http.request.env)
File ".../werkzeug/local.py", line 509, in _get_current_object
    raise RuntimeError(unbound_message)
RuntimeError: object is not bound

Odoo 19 reaches it through core too. website.technical.page builds its SQL view from get_static_routes(), which walks the routing map, and website's TestWebsiteTechnicalPage exercises that from a TransactionCase. On a database with this module installed, website_hr_recruitment's TestWebsiteHrRecruitmentTechnicalPage errors out. Crons and shell scripts hit the same wall.

The existing tests never caught it because they all wrap their calls in MockRequest, so a request was always present.

Fix

routing_map() is a model method, so self.env already holds a cursor. The request was never needed. Both helpers become instance methods reading self.env.

They are only ever called as self.<method>() from this module, and the tests already call _endpoint_route_last_version() on a recordset, so no call site changes.

last_version() reads a sequence, so any cursor on the database returns the same value and the cache key is unchanged. TestEndpointCrossEnv still passes: I checked two separate envs and both report the same version.

Test

Added a regression test that builds the map with no request bound.

[OCA-git-bot]

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

[simahawk]

Thanks for you contrib. Do you think it makes sense to keep _get_routing_map_last_version as class method?

[Ricardoalso]

The @classmethod removal LGTM as we are now reading env from self

Version number is missing in the PR description

[omar-d1]

Thanks for you contrib. Do you think it makes sense to keep _get_routing_map_last_version as class method?

Yeah you're right i removed the classmethod from _get_routing_map_last_version and _endpoint_route_registry as well

[simahawk]

@omar-d1 are you here at OCA days?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[SilvioC2C]

LGTM, one minor possible improvement imho

[omar-d1]

@omar-d1 are you here at OCA days?

Unfortunately not, stuck in the Dubai heat
Maybe next year tho 😀

[simahawk]

/ocabot merge patch

@omar-d1 would you mind backporting to 18 pls?

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-159-by-simahawk-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 796b6a9. Thanks a lot for contributing to OCA. ❤️