Skip to content

Add @deprecated to methods in python-nextgen - #15380

Merged
wing328 merged 7 commits into
masterfrom
add-deprecated
May 4, 2023
Merged

wing328 merged 7 commits into
masterfrom
add-deprecated

Conversation

@wing328

@wing328 wing328 commented May 2, 2023 •

Copy link
Copy Markdown
Member

Add (Deprecated) to API methods to indicate it's deprecated.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @spacether (2019/11) @krjakbrjak (2023/02)

@wing328 wing328 added this to the 6.6.0 milestone May 2, 2023
@wing328
wing328 marked this pull request as ready for review May 2, 2023 11:43
@wing328
wing328 marked this pull request as draft May 2, 2023 11:44
@wing328 wing328 closed this May 2, 2023
@wing328 wing328 reopened this May 2, 2023
@wing328
wing328 marked this pull request as ready for review May 3, 2023 01:39
@robertschweizer

Copy link
Copy Markdown
Contributor

You could also add a warnings.warn("POST/GET/PUT my/endpoint is deprecated", DeprecationWarning) call to the _with_http_info function bodies.

@wing328

wing328 commented May 3, 2023

Copy link
Copy Markdown
Member Author

@robertschweizer thanks for the suggestion. Added the warning.

@wing328
wing328 merged commit 6fa089a into master May 4, 2023
@wing328
wing328 deleted the add-deprecated branch May 4, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants