Repository navigation
[python] Import aiohttp-retry lazily - #25677
Open
timonrieger wants to merge 2 commits into
Open
timonrieger wants to merge 2 commits into
timonrieger wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/python/pyproject.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/python/pyproject.mustache:94">
P2: The generated README's install commands do not select this extra. Users who configure retries then hit `ModuleNotFoundError`; document the `[retry]` install command.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| {{#asyncio}} | ||
|
|
||
| [project.optional-dependencies] | ||
| retry = ["aiohttp-retry (>=2.8.3)"] |
Contributor
There was a problem hiding this comment.
P2: The generated README's install commands do not select this extra. Users who configure retries then hit ModuleNotFoundError; document the [retry] install command.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At modules/openapi-generator/src/main/resources/python/pyproject.mustache, line 94:
<comment>The generated README's install commands do not select this extra. Users who configure retries then hit `ModuleNotFoundError`; document the `[retry]` install command.</comment>
<file context>
@@ -84,6 +88,11 @@ dependencies = [
+{{#asyncio}}
+
+[project.optional-dependencies]
+retry = ["aiohttp-retry (>=2.8.3)"]
+{{/asyncio}}
</file context>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiohttp-retries is only used if retries are configured. respect that by moving it to an optional requirement and import it only when needed.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Imports
aiohttp-retrylazily and makes it an optional dependency so generated async Python clients no longer need it unless retries are configured.aiohttp_retryimport into the retry configuration branch and gates type annotations behindTYPE_CHECKING.aiohttp-retryas an optionalretryextra inpyproject.tomlandsetup.py, and removes it from the default requirements.aiohttp-retryinstalled.Written for commit 34bcb29. Summary will update on new commits.