Skip to content

[python] fix mypy error with pycryptodome 4.4 - #25680

Open
timonrieger wants to merge 2 commits into
OpenAPITools:masterfrom
timonrieger:python-pycryptodome-mode
Open

timonrieger wants to merge 2 commits into
OpenAPITools:masterfrom
timonrieger:python-pycryptodome-mode

Conversation

@timonrieger

@timonrieger timonrieger commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

pycryptodome 4.4 types DSS.new(mode=...) as a Literal, which breaks mypy in all python sample CI jobs.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes a mypy error in the Python client signing code caused by pycryptodome 4.4, which types DSS.new(mode=...) as a Literal. The generated signing template now annotates the ECDSA mode constants with Final and casts the mode argument when calling DSS.new, with the cast kept within the flake8 line length limit.

Written for commit 21b35e4. Summary will update on new commits.

View guided diff

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant