Skip to content

[core] Build the operation map for APIs and webhooks with one helper - #25697

Open
ChihweiLHBird wants to merge 1 commit into
OpenAPITools:masterfrom
ChihweiLHBird:refactor/default-generator-share-operation-map
Open

ChihweiLHBird wants to merge 1 commit into
OpenAPITools:masterfrom
ChihweiLHBird:refactor/default-generator-share-operation-map

Conversation

@ChihweiLHBird

@ChihweiLHBird ChihweiLHBird commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Refactor only; no generated output changes.

In DefaultGenerator, the private processOperations and processWebhooks(config, tag, ...) built their OperationMap with the same code: class name, path prefix and, if the generator asks for it, unique nicknames. That code moves to a private toOperationMap(config, tag, ops).

The OperationsMap and WebhooksMap types and the postProcessOperationsWithModels and postProcessWebhooksWithModels hooks are unchanged, and the calls on the generator configuration happen in the same order as before.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Refactors DefaultGenerator to build the OperationMap for APIs and webhooks with a single private helper, toOperationMap. No behavior change; generated output remains identical.

Written for commit c08331b. Summary will update on new commits.

View guided diff

In DefaultGenerator, processOperations and processWebhooks(config, tag,
...) built their OperationMap with the same code: class name, path
prefix and, if the generator asks for it, unique nicknames. That code
moves to a private toOperationMap(config, tag, ops).

The OperationsMap and WebhooksMap types and the
postProcessOperationsWithModels and postProcessWebhooksWithModels hooks
are unchanged, and the calls on the generator configuration happen in
the same order as before.

No generated output changes.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant