Repository navigation
Preserve literal query values and expand array parameters - #3624
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
velo
left a comment
There was a problem hiding this comment.
Compared master and this branch through RequestTemplate.resolve: scalar values were already pct-encoded so they're unaffected, int[]/String[] now expand in query and path instead of sending identity strings, and Iterable/Map/Optional expansion is unchanged under both EXPLODED and CSV. The real behaviour changes are that a literal ?ids=1,2 and an all-scalar template like ?ids={a},{b} now stay one value instead of becoming repeated params. I think that's the right call and it's in the CHANGELOG, but it would be worth calling out the {a},{b} case explicitly in that bullet. @hutiefang76 this now conflicts in CHANGELOG.md (13.18 section, #3658 adds one too), could you merge master and resolve?
Signed-off-by: Marvin Froeder <velo.br@gmail.com> # Conflicts: # CHANGELOG.md
|
Merged master; CHANGELOG.md was removed from the repo so the entry was dropped. |
Literal query commas were treated as collection separators, so
?ids=1,2became?ids=1&ids=2. Primitive-array query-map values and default array expressions also sent Java array identity strings instead of their elements.Preserve literal/scalar query values and expand arrays through the existing element encoders. Collection expressions keep their current
CollectionFormatbehavior, and customParam.Expanderimplementations still receive arrays as whole values. Add regression coverage plus README and 13.18 changelog notes. Mixed literal-comma/collection templates keep their existing expansion behavior, as documented.Validation:
mvn -Pdev -pl core test— 795 tests, no failures, 4 existing skips; Java 8 main toolchain and JDK 27 test JVM.mvn -Pdev validatepassed with a task-local toolchains file registering the installed JDK 11 alongside the existing toolchains.Fixes #3623
Remote Actions currently reports
action_requiredwith no jobs executed; local validation is complete.