Repository navigation
feign-mock: optionally match request URLs without decoding them - #3685
Merged
velo merged 1 commit intoNov 16, 2026
Merged
Conversation
Add MockClient#matchEncodedUrls() so stubs and verifications match the URL the client actually sends, e.g. /files/a%2Fb rather than the decoded /files/a/b. It is opt-in because existing tests stub decoded URLs, so the default behavior is unchanged. Fixes OpenFeign#787 Signed-off-by: Prabhash <8548359+kumarprabhashanand@users.noreply.github.com>
velo
enabled auto-merge (squash)
November 16, 2026 10:57
velo
approved these changes
Nov 16, 2026
velo
left a comment
Member
There was a problem hiding this comment.
LGTM - optional URL matching without decoding in feign-mock is a useful additive feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #787
Existing:
Changes:
MockClient#matchEncodedUrls(). Stubs and verifications then use the URL as sent, e.g./files/a%2Fb.MockClientTeststubs?client_id=7 7).mock/README.asciidoc.Tests:
./mvnw clean install -Dtoolchain.skip(JDK 25) onmockand every module that depends on it (exceptjdk-json, which needs JDK 28): no failures.Question:
14.x? I would be happy to raise a separate follow-up PR.