Repository navigation
Conversation
Distinguish JSON body templates from literal request body parameters. The brace-escaping advice does not decode a static annotation value. Refs OpenFeign#2041 Assisted-by: DeepSeek Assisted-by: Codex
velo
approved these changes
Nov 16, 2026
velo
left a comment
Member
There was a problem hiding this comment.
Good docs update - clarifies literal JSON request body usage.
velo
enabled auto-merge (squash)
November 16, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@BodyJavadoc recommends URL-encoding literal braces without distinguishing static bodies from templates. For example,@Body("%7B%7D")sends those characters as-is instead of sending an empty JSON object.Clarify the escaping advice and point users sending literal JSON to an unannotated
Stringorbyte[]parameter with the default encoder. The README explains the two annotation cases and links to the existing encoder example. Runtime behavior is unchanged.Refs #2041.
Validation:
mvn -Pdev -pl core test: 872 cases, 0 failures/errors, 4 skipped, using JDK 25 and Java 8/25 toolchains.mvn -Pdev validate: all reactor modules passed.doclint=none,legacyMode=true,maven.javadoc.disableNoFonts=true); unresolved-link warnings remain.@Body("%7B%7D")sends{}failed as described above.Prepared with AI assistance (DeepSeek and Codex).