You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to volunteer to add type hints with mypy checks and include a formatting tool like Black or Ruff on the main file and tests. But before I have to ask:
Is introducing a formatting tool an acceptable change? There are some places where I would like to change the styling a bit.
If running a formatting tool on the code is not an option, but type hints are, should they be added inline or in a separate .pyi file?
I'm not looking to be disruptive. I just want to know if this is a nice-to-have or if it's not needed
well, only one: typed code is generally nicer to read and understand :)
also, I want to add that I'd like to help keep this tool as maintainable as possible. I think every modern linter owes a debt to pycodestyle and its friends, and ensuring its long-term health is a great motivation
Activity
asottile commentedon Oct 29, 2025
historically a formatter has been avoided to dogfood pycodestyle on itself
would be open to type hints and checking though but please do so in reviewable patches
curious what the motivation is though?
asottile commentedon Oct 29, 2025
and inline ideally -- though it won't matter for consuming repositories as it is a single file distribution
albertedwardson commentedon Oct 29, 2025
thanks!
well, only one: typed code is generally nicer to read and understand :)
also, I want to add that I'd like to help keep this tool as maintainable as possible. I think every modern linter owes a debt to pycodestyle and its friends, and ensuring its long-term health is a great motivation