Repository navigation
2.1 release #573
Description
I was wondering if it would be possible to cut the 2.1 release?
The https://github.com/PyCQA/pycodestyle/milestone/13 milestone appears to be complete.
If there's anything else that should be done before the release, I'm happy to help.
Reacted by Richard Lewis, Chih-Hsuan Yen and Brandon Birkholz
Activity
IanLee1521 commentedon Sep 15, 2016
Thanks for asking @daspecster ! Actually one thing that would be super helpful, and which I dropped the ball on is updating the changelog with everything that's happened since 2.0. Would that be something you would be willing to help with?
daspecster commentedon Sep 15, 2016
@IanLee1521, sure no problem!
[-]2.1 release?[/-][+]2.1 release[/+]IanLee1521 commentedon Oct 3, 2016
@sigmavirus24 in particular, but anyone that wants to weigh in -- I was just looking over things for the 2.1 release, and I wanted to run something by you. One of the issues that was fixed was #530 which I believe may have had an unexpected side effect.
By changing the name of the program (https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L2050) from
pep8topycodestylethis changes the config section name frompep8topycodestylewhich would break (ignore) anyone's config that was using the old name. In the long run, that is what we want. But as a backwards incompatible change, I think it's an issue to address.I see two paths forward. First is to add logic that would handle either name for the section (around https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L2148), but with a warning that the
pep8section name is deprecated in preference topycodestyle. Or second, keep the change as is, but note it as backwards incompatible and release the next version as 3.0 instead of 2.1. This would also allow for merging in #433.Any thoughts (from anyone) on these two solutions?
daspecster commentedon Oct 3, 2016
My vote would be for option 2 with a message that the '[pep8]' section was deprecated.
Supporting the
['pycodestyle]section is actually one of the changes that I'm looking for.googleapis/google-cloud-python#2020
sigmavirus24 commentedon Oct 3, 2016
I would opt for option 1. But option 2 is suitable for me too.
daspecster commentedon Nov 4, 2016
@sigmavirus24 @IanLee1521, WDYT about cutting a release? Are there any other issues I could help with to get to 2.1 or 3.0?
sigmavirus24 commentedon Nov 4, 2016
@IanLee1521 I'm happy to help by cutting the release.
IanLee1521 commentedon Nov 4, 2016
Done. Sorry for the ridiculous delay. That's on me.
The new release has been cut and pushed to PyPI. Let me know if anyone notices any issues! Thanks for the help @daspecster ! And big thanks to @sigmavirus24 as always!
daspecster commentedon Nov 4, 2016
Thanks @IanLee1521 and @sigmavirus24!