E127: method chaining #898

Activity

1. FichteFoll commented on Dec 18, 2019

   

   FichteFoll

   on Dec 18, 2019

   Contributor

   More actions

   PEP 8 doesn't have anything regarding this style, so it can't serve as a reference. pycodestyle currently expects the expression to proceed at the indent level of the opening paren.

   👍React with 👍1Reacted by anthony sottile
2. fgotzens commented on Dec 19, 2019

   

   fgotzens

   on Dec 19, 2019

   Author

   More actions

   @FichteFoll Hm, okay, thank you for your reply!

   I just checked again and found this kind of indentation is the recommended style of using method chaing as shown in this tutorial linked from the official pandas website.

   I don't really see how to stick to the E127 rule and write readable code at the same time, since you will probably agree that this consumes too much space:

   df = (pd
         .read_csv('very/long/path/to/file/abcdefghijklmnopqrstuvwxyz.csv',
                     index_col='bar', encoding='utf-8')
         .drop(labels='baz', axis=1))

   and this is more than ugly:

   df = (pd.read_csv('very/long/path/to/file/abcdefghijklmnopqrstuvwxyz.csv',
                     index_col='bar', encoding='utf-8')
         .drop(labels='baz', axis=1))

   So how do you think we should proceed here?
3. chaoflow commented on Jan 13, 2020

   

   chaoflow

   on Jan 13, 2020

   More actions

   @fgotzens instead of the outer parentheses, you could use backslashes to escape the line breaks:

   df = pd.read_csv('very/long/path/to/file/abcdefghijklmnopqrstuvwxyz.csv',
                     index_col='bar', encoding='utf-8')\
           .drop(labels='baz', axis=1)
4. fgotzens commented on Jan 13, 2020

   

   fgotzens

   on Jan 13, 2020

   Author

   More actions

   @chaoflow Thanks for the hint! However that does not really solve to problem, as it triggers E126 in the line starting with .drop(labels...) and claiming it to be over-indented.
5. chaoflow commented on Jan 13, 2020

   

   chaoflow

   on Jan 13, 2020

   More actions

   @fgotzens I see the problem. We work around this by using pylint as well and disabling E126 for flake8, see https://gitlab.com/ternaris/marv-robotics/blob/master/setup.cfg
6. sigmavirus24 commented on Jan 13, 2020

   

   sigmavirus24

   on Jan 13, 2020

   Member

   More actions

   The backslash is a hideous way to work around this problem, in my opinion

   👍React with 👍2Reacted by Ben Samuel and anthony sottile
7. chaoflow commented on Jan 13, 2020

   

   chaoflow

   on Jan 13, 2020

   More actions

   @sigmavirus24 An indisputable case would be:

   foo = bar.func(obj.method()
                  .next_method())

   versus over-idented within parentheses

   foo = bar.func(obj.method()
                     .next_method())

   At least emacs with python-mode will auto-align on the former and using the tab key it won't settle for more indentation (the latter), which means to support the latter, there is at least one more tool to be convinced.

   Given that so far I use:

   foo = bar.func(obj
                  .method()
                  .next_method())

   or

   foo = bar.func(obj.method()
                  .next_method())

   or, if the xyz is needed anyway:

   xyz = obj.method()\
            .next_method()
   foo = bar.func(xyz)

   My conclusion: pycodestyle should at least support the backslash use case and it would be great if the over-idented within parentheses use case would be supported as well, though there would be at least one editor to be taught to make use of it.

   As already mentioned, pep8 says nothing about dotted continuation lines within parentheses.
8. asottile

   changed the title [-]E127 method chaining[/-] [+]E127: method chaining[/+] on Jun 14, 2020