Repository navigation
Build apriltag_ros on macOS - #234
Open
lucascolley wants to merge 3 commits into
Open
lucascolley wants to merge 3 commits into
lucascolley wants to merge 3 commits into
Conversation
apriltag_ros was Linux-only ("earlier macOS and Windows builds failed"). The
macOS build only needs -Werror and the GNU-only linker flags
(-Wl,-z,relro,-z,now,-z,defs) left out, which humble's and lyrical's patches
(and rolling's .osx.patch) already did; jazzy's patch didn't.
- Every distribution builds the same apriltag_ros 3.4.0, so replace the four
distribution patches and rolling's .osx.patch with one
shared/patch/ros2-apriltag-ros.patch (OpenCV 5 calib/geometry split + macOS).
- Select apriltag_ros on `not win` instead of `linux`.
- Exclude camera_ros on non-Linux platforms: it needs libcamera (Linux-only),
and apriltag_ros only uses it (exec_depend) for its camera launch file.
apriltag_ros is the only package depending on it.
Verified on osx-arm64: apriltag_ros builds for every distribution, the jazzy
build's apriltag_node starts, and no camera_ros/libcamera recipes are
generated on macOS.
traversaro
reviewed
Nov 18, 2026
|
|
||
| - if: not win | ||
| then: | ||
| - apriltag_ros # macOS needs no -Werror and no GNU linker flags (patch); Windows builds failed |
Member
There was a problem hiding this comment.
I would remove the macos comment, as it it is what we already solved
traversaro
reviewed
Nov 18, 2026
|
|
||
| - if: not linux | ||
| then: | ||
| - camera_ros # libcamera is Linux-only; also dropped from apriltag_ros (only its camera launch file uses it) |
Member
There was a problem hiding this comment.
Why aprital_ros is mentioned here?
Member
|
For reference, the macos change was upstreamed in https://github.com/christianrauch/apriltag_ros/pull/66/changes , when it is upstreamed we may need to go back to distro-specific patches. |
Collaborator
|
@lucascolley can you please address Silvio’s comments so we can merge here? |
lucascolley
commented
Nov 20, 2026
lucascolley
left a comment
Author
There was a problem hiding this comment.
@Tobias-Fischer addressed
|
|
||
| - if: not linux | ||
| then: | ||
| - camera_ros # libcamera is Linux-only; also dropped from apriltag_ros (only its camera launch file uses it) |
|
|
||
| - if: not win | ||
| then: | ||
| - apriltag_ros # macOS needs no -Werror and no GNU linker flags (patch); Windows builds failed |
traversaro
approved these changes
Nov 20, 2026
Collaborator
|
Have cancelled CI for now to free up resources for the humble & jazzy rebuilds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build
apriltag_roson macOS, for tartanroboticscollective/ros2-workshop-turtlebot3#29.LLM text:
apriltag_ros was Linux-only ("earlier macOS and Windows builds failed"). The
macOS build only needs -Werror and the GNU-only linker flags
(-Wl,-z,relro,-z,now,-z,defs) left out, which humble's and lyrical's patches
(and rolling's .osx.patch) already did; jazzy's patch didn't.
distribution patches and rolling's .osx.patch with one
shared/patch/ros2-apriltag-ros.patch (OpenCV 5 calib/geometry split + macOS).
not wininstead oflinux.and apriltag_ros only uses it (exec_depend) for its camera launch file.
apriltag_ros is the only package depending on it.
Verified on osx-arm64: apriltag_ros builds for every distribution, the jazzy
build's apriltag_node starts, and no camera_ros/libcamera recipes are
generated on macOS.