Unable to add more than one cell comment #2779

Activity

1. SheetJSDev commented on Sep 2, 2022

   

   SheetJSDev

   on Sep 2, 2022

   Contributor

   More actions

   What version of Excel are you using? Can you share the bad file as well as the comment structure for one of the comments that was removed?

   Excel recently changed how comments worked, and SheetJS shifted to support the new threaded comments, so it's possible the fallback isn't compatible with some older versions.
2. AbhinanduReddy commented on Sep 2, 2022

   

   AbhinanduReddy

   on Sep 2, 2022

   Author

   More actions

   Thank you for responding i have used the latest version now I'm not getting error, but Thereaded comments are coming blank now
3. AbhinanduReddy commented on Sep 2, 2022

   

   AbhinanduReddy

   on Sep 2, 2022

   Author

   More actions

   
   
4. SheetJSDev commented on Sep 2, 2022

   

   SheetJSDev

   on Sep 2, 2022

   Contributor

   More actions

   What version of Excel are you using?

   Also, can you test the attached file? comments_example.xlsx

   It was generated as follows:

   var wb = XLSX.utils.book_new();
   
   var ws = XLSX.utils.aoa_to_sheet([["A1"], ["A2"]]);
   
   if(!ws.A1.c) ws.A1.c = [];
   ws.A1.c.push({a:"SheetJS", t:"This comment is visible"});
   
   if(!ws.A2.c) ws.A2.c = [];
   ws.A2.c.hidden = true;
   ws.A2.c.push({a:"SheetJS", t:"This comment will be hidden"});
   
   XLSX.utils.book_append_sheet(wb, ws, "Sheet1");
   
   
   var ws = XLSX.utils.aoa_to_sheet([["A1"], ["A2"]]);
   
   if(!ws.A1.c) ws.A1.c = [];
   ws.A1.c.push({a:"SheetJS", t:"This is not threaded"});
   
   if(!ws.A2.c) ws.A2.c = [];
   ws.A2.c.hidden = true;
   ws.A2.c.push({a:"SheetJS", t:"This is threaded", T: true});
   ws.A2.c.push({a:"JSSheet", t:"This is also threaded", T: true});
   
   
   XLSX.utils.book_append_sheet(wb, ws, "Sheet2");
   XLSX.writeFile(wb, "comments_example.xlsx")
5. SheetJSDev

   closed this as completedin 6c9010fon Sep 2, 2022
6. SheetJSDev commented on Sep 2, 2022

   

   SheetJSDev

   on Sep 2, 2022

   Contributor

   More actions

   The updated logic is now aligned with how the Pro builds write comments.

   SheetJSThreadedComments.xlsx
   small example generated using the same example code. That should have visible comments both in Excel 2019 and in older versions of Excel. If the file is showing blank comments or looks corrupted, let us know what version of Excel you are using.
7. SheetJS

   locked and limited conversation to collaborators on Dec 29, 2022
8. eyesplitter

   added a commit that references this issue on Apr 2, 2024

   comment fallback (fixes SheetJS#2779 h/t @AbhinanduReddy)

   This issue will close once commit 6c9010f is merged into the 'master' branch.

   6c9010f