Repository navigation
fix: don't let trailing whitespace control strip a partial's leading whitespace - #2145
Open
nagibatorz wants to merge 2 commits into
Open
nagibatorz wants to merge 2 commits into
nagibatorz wants to merge 2 commits into
Conversation
…espace A template ending in -%} or -}} leaves parse_context.trim_whitespace set, and PartialCache.load parses the partial with the parent template's parse context, so the partial's leading whitespace is stripped. Repro for Shopify#2140.
A template ending in -%} or -}} leaves trim_whitespace set on the shared parse context, and PartialCache.load parsed partials with that context, stripping the partial's leading whitespace. Clear the flag while parsing the partial and restore it afterwards. Fixes Shopify#2140.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2140. A template ending in -%} or -}} leaves trim_whitespace set on the shared parse context, and PartialCache.load parsed partials with that context, stripping the partial's leading whitespace. Clear the flag while parsing the partial and restore it afterwards. Validation: new test fails on clean main and passes with the fix; full suite 1063 runs, 0 failures.