You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Respect selected partners in starter analysis - #1402
An explicit Clerk selection paired with a WorkOS mention could return WorkOS in inferredPartnerIds while the recipe correctly kept Clerk. Pass the selected partners into the existing inference filter so the analysis respects the same constraints.
AI review notes:
Reproduced through analyzeApplicationStarterServer using a composed input with Clerk selected and “Build an app with WorkOS authentication.” as the brief. Before: inferred WorkOS, recipe Clerk. After: no conflicting inferred partner, recipe Clerk.
Adds a regression covering the actual analysis result and recipe. Full pnpm test and the normal commit hook passed.
Follows up on the separate inference concern from the CodeRabbit review on #998. That PR's Lovable activation change was already covered by main.
Summary by CodeRabbit
Bug Fixes
Application setup recommendations now retain explicitly selected partners when they are compatible with the requested integration.
Setup recipes exclude incompatible authentication options. For example, selecting Clerk while requesting WorkOS authentication includes Clerk and does not infer WorkOS as a partner.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
No actionable comments were generated in the recent review.
Walkthrough
Server-side application-starter analysis now derives inferred partner IDs from selected partner IDs and compatible partners. A test covers selecting Clerk for a WorkOS authentication request.
Changes: Partner inference
Layer / File(s)
Summary
Derive inferred partners and test selection src/utils/application-starter.server.ts, tests/application-starter-partners.test.ts
Partner inference uses selected partner IDs with the compatible-partner set. The test verifies that selecting Clerk retains Clerk, infers no partners, and excludes WorkOS from the resulting recipe.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: e9759c43-0e65-4616-b7b5-d74357ff0fa2
Commits
Reviewing files that changed from the base of the PR and between 766b336 and 285877a.
Files selected for processing: 1
tests/application-starter-partners.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This is up to date with main now and ready for the required maintainer review.
AI review notes:
Resolved the test-file conflict by keeping both the migration coverage from main and the selected-partner regression. The fix itself is unchanged.
On 285877a, the normal commit hook passed TypeScript, lint, 723 unit tests, 2,279 chat tests and 20 desktop tests, with the existing skips. New-head CI is running; the required Website Maintainers review remains.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit Clerk selection paired with a WorkOS mention could return WorkOS in
inferredPartnerIdswhile the recipe correctly kept Clerk. Pass the selected partners into the existing inference filter so the analysis respects the same constraints.Summary by CodeRabbit