Skip to content

Respect selected partners in starter analysis - #1402

Open
tannerlinsley wants to merge 2 commits into
mainfrom
taren/starter-analysis-partner-constraints
Open

tannerlinsley wants to merge 2 commits into
mainfrom
taren/starter-analysis-partner-constraints

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

An explicit Clerk selection paired with a WorkOS mention could return WorkOS in inferredPartnerIds while the recipe correctly kept Clerk. Pass the selected partners into the existing inference filter so the analysis respects the same constraints.

AI review notes:
Reproduced through analyzeApplicationStarterServer using a composed input with Clerk selected and “Build an app with WorkOS authentication.” as the brief. Before: inferred WorkOS, recipe Clerk. After: no conflicting inferred partner, recipe Clerk.
Adds a regression covering the actual analysis result and recipe. Full pnpm test and the normal commit hook passed.
Follows up on the separate inference concern from the CodeRabbit review on #998. That PR's Lovable activation change was already covered by main.

Summary by CodeRabbit

  • Bug Fixes
    • Application setup recommendations now retain explicitly selected partners when they are compatible with the requested integration.
    • Setup recipes exclude incompatible authentication options. For example, selecting Clerk while requesting WorkOS authentication includes Clerk and does not infer WorkOS as a partner.

@tannerlinsley
tannerlinsley requested a review from a team October 20, 2026 07:37
@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 285877a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Server-side application-starter analysis now derives inferred partner IDs from selected partner IDs and compatible partners. A test covers selecting Clerk for a WorkOS authentication request.

Changes: Partner inference

Layer / File(s) Summary
Derive inferred partners and test selection
src/utils/application-starter.server.ts, tests/application-starter-partners.test.ts
Partner inference uses selected partner IDs with the compatible-partner set. The test verifies that selecting Clerk retains Clerk, infers no partners, and excludes WorkOS from the resulting recipe.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: abeuty

Merge Risk: Minimal · up to 28587

Explicit partner selections are respected during inference. No merge-blocking issue was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: ensuring starter analysis respects selected partners.
Docstring Coverage Passed Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e9759c43-0e65-4616-b7b5-d74357ff0fa2
Commits

Reviewing files that changed from the base of the PR and between 766b336 and 285877a.

Files selected for processing: 1

  • tests/application-starter-partners.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 285877a Commit Preview URL

Branch Preview URL
Nov 05 2026, 08:40 PM

@tannerlinsley

Copy link
Copy Markdown
Member Author

This is up to date with main now and ready for the required maintainer review.

AI review notes:
Resolved the test-file conflict by keeping both the migration coverage from main and the selected-partner regression. The fix itself is unchanged.
On 285877a, the normal commit hook passed TypeScript, lint, 723 unit tests, 2,279 chat tests and 20 desktop tests, with the existing skips. New-head CI is running; the required Website Maintainers review remains.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant