Repository navigation
unhandled Throwable in WebSocketClient #1460
Description
Describe the bug
We got few times a "Got fatal error during frame processing" message
WebSocketClient thread is dead and no callback nor any exception is thrown back.
To Reproduce
We were not able to reproduce the issue in lab.
Environment
- Version used: 1.5.6
- Java version: jdk21
- Operating System and version: linux red hat 8.10
Additional context
We found that an issue was opened #1160 and an pull request was done on that subject #1223
The pull request title specified "added java.lang.Error handling in WebSocketImpl and WebSocketServer"
And someone reported that issue too #1369 (closed missing-information cannot-reproduce)
The WebsocketImpl throw the errors...
catch (VirtualMachineError | ThreadDeath | LinkageError e) {
log.error("Got fatal error during frame processing");
throw e;
WebSocketServer and WebSocketWorker classes are catching the Error and closing/cleaning while WebSocketClient doesn't...
Expected behavior
We expect the websocket client to throw an exception or close the connection
Activity
Handle fatal Errors in WebSocketClient read loop (TooTallNate#1460)
Restore unrelated lines; keep only fatal Error catch (TooTallNate#1460)
Add regression test for fatal Error in client read loop (TooTallNate#…
Drop unrelated changes; isolate fatal Error catch (TooTallNate#1460)
Override copyInstance so fatal Error draft survives engine copy (TooT…