Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/desktop/test/companion.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -505,4 +505,8 @@ test("companion fallback makes uncertain and resolving deliveries explicit witho
const approval = mobileItem({ id: "approval", kind: "approval", question: "Deploy?", answer: "yes", delivery: "uncertain", at: "now" });
assert.equal(approval.kind, "notice");
assert.match(String(approval.text), /Delivery uncertain/);
// A withdrawn approval closes as "no"; a phone that reads only `answer` must not show it declined (CF-6 #279, finding 7).
const withdrawn = mobileItem({ id: "approval", kind: "approval", question: "Deploy?", answer: "no", withdrawn: "native", at: "now" });
assert.equal(withdrawn.kind, "notice");
assert.match(String(withdrawn.text), /Request withdrawn/);
});
7 changes: 4 additions & 3 deletions docs/human-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,10 @@ paired desktops and the phone carry it with no new event type. This is the reque
`withdrawn`). Nothing replayed, reloaded or reconnected answers a request.
- **Two clients at once.** The desktop and the phone race through one broker: one answer is accepted,
the card names who gave it, and the other is refused, with a 409 for the phone.
- **The phone** gets `answeredBy`, `delivery` and `withdrawn` on approvals. Today's iPhone build reads
only `answer`, so a withdrawn approval still reads as declined there. A question's notice says when
delivery is uncertain.
- **The phone** gets `answeredBy` and `delivery` on an open or answered approval. A withdrawn, sending
or uncertain approval reaches it as a notice that says so ("Request withdrawn. Nothing more can be
approved."), so the iPhone app no longer shows a withdrawn approval as declined. A question's notice
says when delivery is uncertain.
- **Who answered** is the client that made the decision: this Mac's window (`desktop`), a desktop
paired through the host (`paired-desktop`), or the phone. Switching a thread to YOLO answers what is
waiting as whichever of them switched it.
Expand Down
Loading