Skip to content

Invalidate retained PR data after visibility loss - #354

Merged
BunsDev merged 2 commits into
cr2-read-servicefrom
cr2-cache-denial
Oct 21, 2026
Merged

BunsDev merged 2 commits into
cr2-read-servicefrom
cr2-cache-denial

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

After a successful PR read, a 403/404 followed by a network failure could expose old cached content. This repair invalidates affected PR views, inbox entries, and shared file slices, and prevents overlapping searches, transport responses, and account confirmation from restoring denied data. Accessible inbox repositories remain available as explicitly incomplete results.

Stacked on #349. Includes regressions for denied data resurrection, sibling context slices, post-confirmation races, and mixed accessible/denied inbox results.

Validation on 4dd5bb59afd7d55f5c05d5580c7a1d8bb4648698:

  • pnpm build, pnpm typecheck, and pnpm test passed: 1,938 passed, 16 skipped.
  • Focused service suite: 42 passed; three independent review reproductions passed.
  • Authenticated GET-only smoke: connection, resolve, overview, files, and revision-bound context ready against Add main's Code Review read service through gh (CR-2) #349.
  • Independent code review completed with no remaining material findings.

Authenticated renderer navigation and full UI E2E remain part of #346 integration; this service repair does not claim that acceptance.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 21, 2026 12:03am UTC

Request Review

@github-code-quality

github-code-quality Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

cr2-read-service b654734 cr2-cache-denial 4dd5bb5 +/-
64% 65% +1%
View coverage of the 10 most impacted files.
File cr2-read-service b654734 cr2-cache-denial 4dd5bb5 +/-
apps/desktop/sr...ckends/codex.ts 97% 97% 0%
apps/desktop/sr...task-context.ts 99% 99% 0%
apps/desktop/sr...ation-events.ts 98% 98% 0%
apps/desktop/sr...red/evidence.ts 99% 99% 0%
apps/desktop/sr...ain/commands.ts 86% 87% +1%
apps/desktop/sr.../code-review.ts 99% 100% +1%
apps/desktop/sr...TurnContent.tsx 48% 58% +10%
apps/desktop/sr...read-service.ts 0% 98% +98%
apps/desktop/sr...eview/github.ts 0% 99% +99%
apps/desktop/sr...de-review/gh.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 21, 2026 00:51 UTC

This branch was successfully deployed

1 active deployment
Preview — 4dd5bb59 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant