Skip to content

Resolve context paths from command cwd and normalize project boundaries - #360

Merged
BunsDev merged 2 commits into
cf7-contextfrom
cf7-path-repair
Oct 21, 2026
Merged

BunsDev merged 2 commits into
cf7-contextfrom
cf7-path-repair

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Repairs #355's context paths: Codex action paths resolve from the command working directory, then normalized containment determines whether a file belongs to the project. Windows drive/rooted/UNC paths are handled explicitly; ambiguous drive-relative paths stay unnamed. External-file counts deduplicate normalized identities internally without exposing those identities in the UI or saved Notes.

Stacked on #355. Regressions reproduced incorrect command cwd, traversal escape, Windows classification, and external count behavior before their repairs. Independent review found no remaining blockers.

Validation:

  • Final build, typecheck and full unit suite passed: 1,918 passed, 16 skipped; focused task-context suite 23 passed.
  • Final Notes E2E: 4 passed.
  • Full E2E on preceding commit dc5c80c, before the final external-count-only correction: desktop 374 passed, 6 opt-in skips; site 7 passed.
  • The final count correction was separately rechecked through the full unit suite and Notes E2E. Required CI on the published head remains the final merge gate.

This fixes the context map; it does not claim all #280 or human acceptance is complete.

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 21, 2026 12:34am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

cf7-context b654734 cf7-path-repair 0c70c6e +/-
64% 65% +1%
View coverage of the 3 most impacted files.
File cf7-context b654734 cf7-path-repair 0c70c6e +/-
apps/desktop/sr...ckends/codex.ts 97% 97% 0%
apps/desktop/sr...red/evidence.ts 99% 99% 0%
apps/desktop/sr...task-context.ts 99% 100% +1%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch was successfully deployed

1 active deployment
Preview — 0c70c6ed Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant