Repository navigation
LM-3 and LM-5: signed delivery of isolated local execution and admission policy - #423
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preserves the exact reviewed source tree from PR #417 while replacing its unsigned ancestry with a signed delivery commit.
BunsDev
force-pushed
the
lm3-signed-delivery
branch
from
October 28, 2026 11:13
82d3358 to
4745b72
Compare
* LM-5 slice 1: admit a local Codex child on its effective configuration (#380) Before a local child opens or resumes a thread, CodexBackend reads the child's own config/read (effective configuration, the layer that set each key, every layer's contents and hash) and configRequirements/read, and admitLocalConfiguration (engine/local-models/run-policy.ts) admits it only when every governed key comes from Modex's session flags, no project layer is loaded, the private home is empty, no managed layer touches a governed key, no managed requirements apply, and the effective destination, wire, credential reference, context and tools are exactly what Modex passed. Otherwise the turn fails naming the layer and key; nothing is rewritten or sent. The admitted provenance is kept with the child. A model/rerouted notification on a local turn interrupts it and reports it failed. Real-CLI evidence (codex-cli 0.164.0): config/read reports origins and layers as the policy expects; a requirements.toml in the private home is not read; a 307 from the configured loopback server is followed with the full body and never with the token, a 302 as a bodyless GET. The opt-in native test records both. This is the refusal boundary #417's review asked for; wiring local execution into the product stays a separate decision. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix: retain rerouted local turns until native termination * docs: record integrated LM5 delivery validation --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
BunsDev
changed the title
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage-agent
View coverage of the 6 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
This was referenced Oct 28, 2026
BunsDev
added a commit
that referenced
this pull request
Nov 1, 2026
The CF-7 verification plan said step-to-check linking stayed open; Val retired it on 2026-10-23. The worktree-hygiene plan's landing box was unticked though #171 landed. local-models.md placed LM-5 slice 1 on a branch; it is on main through #423. code-review.md still said nothing had shipped; CR-1 to CR-7 are on main and in v0.4.0 behind the modex.codeReview switch. The CF, CR and LM docs now point at the status checklist table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This delivers the reviewed LM-3 foundation from #417 and the LM-5 effective-configuration policy from #419 and #424 with signed history. Production local execution remains disconnected: an attempted local target is refused without starting a child or falling back to cloud execution. Qualification fixtures retain the isolated Codex child, effective-destination admission checks and truthful reroute termination that waits for native termination before releasing the turn.
The LM-3 replacement preserves the reviewed implementation on main base
b64361750983068160fe95293192ccea03000f88. PR #424 merged into this branch as0956376f1e0a33e331afe47e44fba659132730fc; its complete tree exactly matches reviewed LM-5 candidatee0a03efb741fe264513b4787e4ef2daff03e91a8. The subsequent test repair removes partial regex escaping identified by CodeQL alert #28 and compares the expected error text literally, retaining checks for both configuration layer and governed key.Validation: the reviewed LM-5 candidate passed root build, typecheck, 2,219 unit tests with 26 skips, and root E2E with 470 desktop passes, seven desktop skips and seven site passes. The assertion repair passed main-process build and all five focused policy tests; independent review found no blockers. The repaired branch also passed the full root build and unit command: 2,219 passed, 26 skipped, zero failures or cancellations. CodeQL alert #28 was confirmed fixed on
d3d61ad; that head’s hosted macOS run failed the Jev Settings click and teardown (472 desktop passed, four skipped, one failed). Current signed head618027ed3344274f6bad68cf36da4e182be23dbfmerges main7a01df2, including the landed CR-6 and Notes repairs. Freshpnpm build && pnpm testpassed: 2,224 passed, 26 skipped, zero failures or cancellations. Five local repetitions of the Jev case passed in 44.8s; this did not establish the hosted failure’s cause. Current-head hosted CI run 40745984553 passed: 473 desktop E2E tests with four skips, seven site tests and 43 iPhone tests with zero failures. All current-head checks, including TypeScript coverage, CodeQL and native Linux/Windows checks, passed. The protected merge queue remains required. Earlier failed hosted runs remain recorded; this does not claim those failures resolved.Refs #379, #380, #376, #417, #419. The original PRs remain open until this delivery reaches main. Product admission, live local-server acceptance, redirect and managed-policy qualification, offline operation and runtime/UI acceptance remain open; this PR does not close those gates.