Skip to content

Add support for Python 3 #280

Closed
Closed

Description

@tdruez

A must have for ABOUT files adoption in modern codebase.

Activity

  1. chinyeungli commented on Sep 25, 2017

    @chinyeungli
    Contributor

    merged changes to develop

  2. tdruez commented on Oct 2, 2017

    @tdruez
    ContributorAuthor

    Thanks for the merge, but I'm re-opening the issue to add the following:

    • Remove hardcoded python2.7 in code
    • Add python3 support in documentation
    • Add python3 in tests integration
    • Add python3 in setup.py
  3. reopened this on Oct 2, 2017
  4. 24 remaining items

  5. tdruez commented on Nov 15, 2017

    @tdruez
    ContributorAuthor

    For reference:

    Running aboutcode-toolkit version 3.0.0
    Generating .ABOUT files...
    Traceback (most recent call last):
     File "aboutcode-toolkit-280-python3-cleanup/src/attributecode/model.py", line 1485, in valid_api_url
       request = urllib2.Request(api_url)
    AttributeError: module 'urllib' has no attribute 'Request'
    
  6. tdruez commented on Nov 15, 2017

    @tdruez
    ContributorAuthor

    This could have been prevented with the proper (missing at the moment) tests for those functions:

    • api.request_license_data
    • model.valid_api_url
    • model.pre_process_and_fetch_license_dict
    • model.is_valid_url
  7. chinyeungli commented on Nov 15, 2017

    @chinyeungli
    Contributor

    Thanks. I will update those test functions.

  8. added a commit that references this issue on Nov 15, 2017
  9. chinyeungli commented on Nov 15, 2017

    @chinyeungli
    Contributor

    @tdruez
    For some reasons, when I run the gen command on my windows machine, it gets

    Running aboutcode-toolkit version 3.0.0
    Generating .ABOUT files...
    Traceback (most recent call last):
      File "C:\Users\CYL\git\aboutcode-toolkit\bin\about-code-script.py", line 11, in <module>
        load_entry_point('aboutcode-toolkit', 'console_scripts', 'about-code')()
      File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 722, in __call__
        return self.main(*args, **kwargs)
      File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 697, in main
        rv = self.invoke(ctx)
      File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 1066, in invoke
        return _process_result(sub_ctx.command.invoke(sub_ctx))
      File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 895, in invoke
        return ctx.invoke(self.callback, **ctx.params)
      File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 535, in invoke
        return callback(*args, **kwargs)
      File "c:\users\cyl\git\aboutcode-toolkit\src\attributecode\cmd.py", line 203, in gen
        errors, abouts = gen.generate(
    AttributeError: 'AboutCommand' object has no attribute 'generate'
    

    However, it works fine on my Ubuntu VM.

  10. chinyeungli commented on Nov 15, 2017

    @chinyeungli
    Contributor

    related issue #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions