You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tdruez
For some reasons, when I run the gen command on my windows machine, it gets
Running aboutcode-toolkit version 3.0.0
Generating .ABOUT files...
Traceback (most recent call last):
File "C:\Users\CYL\git\aboutcode-toolkit\bin\about-code-script.py", line 11, in <module>
load_entry_point('aboutcode-toolkit', 'console_scripts', 'about-code')()
File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 722, in __call__
return self.main(*args, **kwargs)
File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 697, in main
rv = self.invoke(ctx)
File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "c:\users\cyl\git\aboutcode-toolkit\lib\site-packages\click\core.py", line 535, in invoke
return callback(*args, **kwargs)
File "c:\users\cyl\git\aboutcode-toolkit\src\attributecode\cmd.py", line 203, in gen
errors, abouts = gen.generate(
AttributeError: 'AboutCommand' object has no attribute 'generate'
Activity
Replace old-style `except` statements with modern `as` syntax #280
Add basic Python 3 compatiblity fixing imports #280
chinyeungli commentedon Sep 25, 2017
merged changes to
developtdruez commentedon Oct 2, 2017
Thanks for the merge, but I'm re-opening the issue to add the following:
Add Python 3 compatibility for the csv output #280
Bump dependencies to current versions #280 #291
Bump dependencies to current versions #280 #291
Use unicode everywhere, cleanup imports #280
Improve error string handling. Make test pass on Py2 #280
Cleanup test for py.test warning #280
24 remaining items
Merge develop resolving conflicts #280
Do not use datafiles in setup.py #280
Fix Python2/Python3 compatibility for the api module #280
tdruez commentedon Nov 15, 2017
For reference:
Fix Python2/Python3 compatibility for the `model` module #280
tdruez commentedon Nov 15, 2017
This could have been prevented with the proper (missing at the moment) tests for those functions:
api.request_license_datamodel.valid_api_urlmodel.pre_process_and_fetch_license_dictmodel.is_valid_urlchinyeungli commentedon Nov 15, 2017
Thanks. I will update those test functions.
Remove un-used imports #280
chinyeungli commentedon Nov 15, 2017
@tdruez
For some reasons, when I run the gen command on my windows machine, it gets
However, it works fine on my Ubuntu VM.
tdruez commentedon Nov 15, 2017
@chinyeungli looks like some name shadow issue.
We import
genfromgeneratein https://github.com/nexB/aboutcode-toolkit/blob/a0d74fd460928d97ba30543b4b80ab15cd575c44/src/attributecode/cmd.py#L33 then we define a function namedgenin the same module https://github.com/nexB/aboutcode-toolkit/blob/a0d74fd460928d97ba30543b4b80ab15cd575c44/src/attributecode/cmd.py#L186Rename command function names to avoid conflict with module names #280
chinyeungli commentedon Nov 15, 2017
related issue #297
Refine import to prevent name conflict #280
Add FetchLicenseTest for basic test coverage #280