Skip to content

Got "CC-BY-NC-SA-3.0 AND CC-BY-SA-3.0" for file mentioning elements under CC-BY-SA-3.0 #3615

Closed

Description

@camillem

Description

Not sure if this is a bug, but an issue, at least for me.
When scanning the attached custom-content.html file (attached) , I get "CC-BY-NC-SA-3.0 AND CC-BY-SA-3.0" for detected_license_expression_spdx, while the content only refers to elements under CC-BY-SA-3.0. (see attached json file)

How To Reproduce

git checkout v32.0.8
./configure
source venv/bin/activate
scancode -h
scancode --license --copyright --json-pp scancode_result.json custom-content.html 

System configuration

For bug reports, it really helps us to know:

  • What OS are you running on? Ubuntu 22.04.3 LTS
  • What version of scancode-toolkit was used to generate the scan file? v32.0.8
  • What installation method was used to install/run scancode? source download

custom-content.html.txt

scancode_result.json

Activity

  1. pombredanne commented on Dec 1, 2023

    @pombredanne
    Member

    Thanks for the report. I will make a dedicated fix commit to show what the simple fix is FWIW.

  2. dotarjun commented on Dec 1, 2023

    @dotarjun
    Contributor

    Hey do you mind if I give this a shot?

  3. pombredanne commented on Dec 2, 2023

    @pombredanne
    Member

    @dotarjun sure thing! please do and thank you.

  4. pombredanne commented on Dec 4, 2023

    @pombredanne
    Member

    @dotarjun here is a change that may fix things:
    In src/licensedcode/data/rules/cc-by-nc-sa-3.0_22.RULE add double curly braces to make a part a "key phrase":

    ---
    license_expression: cc-by-nc-sa-3.0
    is_license_notice: yes
    relevance: 100
    ignorable_urls:
        - http://creativecommons.org/licenses/by-nc-sa/3.0/deed.en_US
    ---
    
    This book is licensed under a Creative Commons 
    http://creativecommons.org/licenses/by-nc-sa/3.0/deed.en_US [{{Attribution-NonCommercial-ShareAlike 3.0}} Unported] license. 
    For more information, please see the Creative Commons page.
  5. AyanSinhaMahapatra commented on Jan 17, 2024

    @AyanSinhaMahapatra
    Member

    @dotarjun ping!

  6. dotarjun commented on Jan 17, 2024

    @dotarjun
    Contributor

    Hey, I totally missed this. I'll push the change asap

  7. added a commit that references this issue on Jan 19, 2024
  8. camillem commented on Feb 6, 2024

    @camillem
    ContributorAuthor

    Thanks for the quick fix :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions