Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Session options RFD from Draft to Preview for feedback from Agent and Client implementers.
session/optionsand initialconfigOptionsremain behindunstable_session_options. No schemas, feature gates, or wire requirements change.The RFD now links to released SDK support and wire tests instead of listing planned examples. The draft guides and v2 overview also name
session/forkalongside the other setup methods that accept initial values. The fork field itself landed in #2794.What to try
Use
npx -y @agentclientprotocol/claude-agent-acp@0.109.1-preview.5as the Agent command. After checking the advertised capability, callsession/optionsfor a workspace, then send a model and reasoning level onsession/newand compare the resulting options. For an existing session, compare the preview withsession/resumein the same workspace. This package includes the v1 changed-workspace fix.Rust SDK 5.3.0 and TypeScript SDK 2.7.0 include the fork field for both protocol versions. Delta uses discovery before the first prompt and sends choices on new. Zed uses the initial values on new behind
acp-beta, without querying first.Validation
npm run checkpassed. Mint validation of the five changed MDX pages passed (mint validate --no-build --files …).session/newthen applied the selected model on both versions.mint validatestops atdocs/get-started/registry.mdx:954:7on an SVG doctype. The same error reproduces on unmodifiedmainat1a52ecae.Please leave this PR open for a few days for feedback before merging.