Repository navigation
chore: infra team owns CI and release automation - #135
Open
Gkrumbach07 wants to merge 1 commit into
Open
Gkrumbach07 wants to merge 1 commit into
Gkrumbach07 wants to merge 1 commit into
Conversation
The workflows, the release scripts and the upstream bump bot hold the tokens that publish packages and push branches. Simon asked for the organization's infra team to review changes to them; this makes @ai-openshell/infra the code owner of .github/, scripts/release/, scripts/retag-image.sh, scripts/branch-tip.sh and deploy/ci/upstream/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simon's follow-up from the GHCR/environments discussion: workflow changes should get a security review from infra.
Makes
@ai-openshell/infrathe code owner of:.github/: workflows and CODEOWNERS itselfscripts/release/,scripts/retag-image.sh,scripts/branch-tip.sh: whatpublish.ymlandpromote-latestrun with the release tokendeploy/ci/upstream/: the bump bot, which runs with the bump-bot App's tokenThese lines come after
* @Gkrumbach07, and in CODEOWNERS the last matching rule wins. So for these paths only infra counts as a code owner, and a CI change needs an approval from someone ininfra.Infra decides two things:
infraneeds write access to the repo for the rule to take effect; GitHub ignores a team without it. I can't check repo team access with write permission.@Gkrumbach07 @ai-openshell/infra.Merge order: independent of #133 and #134. If this lands first, those two need an infra approval as well, which seems right since they change the workflows.
🤖 Generated with Claude Code