Skip to content

perf(pypi): parse the env markers once per requirement - #30

Closed
aignas wants to merge 1 commit into
fix.aignas.version-hardening-10-marker-parse-oncefrom
fix.aignas.version-hardening-11-marker-parse-once-callers
Closed

aignas wants to merge 1 commit into
fix.aignas.version-hardening-10-marker-parse-oncefrom
fix.aignas.version-hardening-11-marker-parse-once-callers

Conversation

@aignas

@aignas aignas commented Nov 20, 2026

Copy link
Copy Markdown
Owner

The markers of the requirements and of the uv.lock packages and
dependencies are evaluated for every target platform. Parse them once
before looping over the platforms, which makes each evaluation after
the first one about 3 times cheaper.

The invalid markers are now reported even if there are no platforms
to evaluate them for.

Work towards #19

The markers of the requirements and of the `uv.lock` packages and
dependencies are evaluated for every target platform. Parse them once
before looping over the platforms, which makes each evaluation after
the first one about 3 times cheaper.

The invalid markers are now reported even if there are no platforms
to evaluate them for.
@aignas

aignas commented Nov 20, 2026

Copy link
Copy Markdown
Owner Author

This PR was prepared by an AI agent (Claude Code) working for the author. The author reads the review comments and decides how they are handled; any reply posted by the agent will say so.

This comment was automatically generated by an AI agent and was not reviewed by the author.

@aignas

aignas commented Nov 20, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the stack that was rebuilt on the latest main and sent upstream: bazel-contrib#4543 to bazel-contrib#4550.

This comment was automatically generated by an AI agent and was not reviewed by the author.

@aignas aignas closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant