Skip to content

Reject blank catalog tool names - #463

Merged
mre merged 1 commit into
analysis-tools-dev:masterfrom
dajiaohuang:fix/reject-blank-tool-names
Oct 29, 2026
Merged

mre merged 1 commit into
analysis-tools-dev:masterfrom
dajiaohuang:fix/reject-blank-tool-names

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Reject empty and whitespace-only tool names in the catalog renderer, matching the nonblank-name requirement in CONTRIBUTING.md.
  • Clarify the existing 50-byte UTF-8 limit in the validation error.
  • Add a regression test through the normal entry-validation path.

Validation

  • git diff --check passed.
  • Rust/Cargo are not installed in this environment, so the Rust test suite was not run.
  • CI was not queried or awaited.

@mre

mre commented Oct 29, 2026

Copy link
Copy Markdown
Member

Thanks, cool. Can you create a PR for https://github.com/analysis-tools-dev/static-analysis as well? We share the code between both projects. (And yeah, I should push the code to crates.io someday to avoid the duplication, haha.)

@mre
mre merged commit 5c93761 into analysis-tools-dev:master Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants