Repository navigation
Keep parenthesized expressions in identifier lists - #932
Closed
adenzhou1350 wants to merge 2 commits into
Closed
adenzhou1350 wants to merge 2 commits into
adenzhou1350 wants to merge 2 commits into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
Author
|
Closing this proposal following the maintainer's final 0.6.1 release and end-of-maintenance announcement. Since no further upstream releases are planned, I am withdrawing my pending contribution. The fork branch and existing validation remain available; no further review or CI action is requested. Thank you for maintaining sqlparse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #343.
Bare parenthesized expressions break a comma-separated identifier list. For example,
SELECT a, b, (a-b) FROM blagroups onlya, b, leaving the last expression on the wrong line after reindent.Accept parenthesized list items and group VALUES before identifier lists, keeping each top-level VALUES row separate. Expressions inside those rows still form their own lists.
Tests cover first/middle/last items, adjacent and nested parentheses, scalar subqueries, reindent output and VALUES row boundaries. The original 12 new cases had 11 failures before the fix; those original before/after results remain historical.
Current refresh — November 2
Merged upstream
masterat09dbe1eec31einto signed-off head13d1eca56265. The only manual conflict was CHANGELOG. Keep the upstream file byte-for-byte and drop this PR's unreleased entry, so an unmerged fix is not described as part of the already published final 0.6.1 release. The original production and test added/removed lines are unchanged; the PR now touches three files.Fresh native Windows Python 3.14, using the repository's uv dev environment and with third-party pytest plugin autoload disabled:
ruff check sqlparse/and scopedgit diff --checkpass.The earlier Python 3.12/3.14 518-pass run and wide-column linear-scaling measurements belong to the prior head; they were not rerun as current-head evidence. Linux/macOS and other Python versions remain for hosted CI. Current-head CI is pending.
Upstream maintenance status
Upstream's final 0.6.1 release announces the end of active development/maintenance and that no further releases, including security fixes, are planned. The repository is currently not archived. This refresh preserves that announcement and does not imply a planned upstream release; whether this proposal is accepted remains the maintainer's decision.
AI-assisted implementation and validation.