Activity

1. ernistkg commented on Feb 5, 2017

   

   ernistkg

   on Feb 5, 2017

   More actions

   Problem

   I have researched this issue and found reason why this doesn't work.

   In thing.events.js file
   ./server/api/thing/thing.events.js

   // Register the event emitter to the model events
   for(var e in events) {
     let event = events[e];
     Thing.schema.post(e, emitEvent(event));
   }

   As you can see inside for loop remove and save events are applied to Thing Schema thorough POST HOOKS . And this hooks never called. I think this happens because we are applying HOOKS to Shema after Thing model is already created in model file:

   export default mongoose.model('Thing', ThingSchema);

   Solution

   Problem solved when I applied hooks before model created:
   In thing.model.js file
   ./server/api/thing/thing.model.js

   'use strict';
   
   import mongoose from 'mongoose';
   
   var ThingSchema = new mongoose.Schema({
     name: String,
     info: String,
     active: Boolean
   });
   
   require('./thing.events').applyHooks(ThingSchema);
   
   export default mongoose.model('Thing', ThingSchema);

   And thing.events.js was modified to export applyHook function which will apply schema hooks before mongoose model is created.
   ./server/api/thing/thing.events.js

   /**
    * Thing model events
    */
   
   'use strict';
   
   import {EventEmitter} from 'events';
   var ThingEvents = new EventEmitter();
   
   // Set max event listeners (0 == unlimited)
   ThingEvents.setMaxListeners(0);
   
   // Model events
   var events = {
     save: 'save',
     remove: 'remove'
   };
   
   function emitEvent(event) {
     return function(doc) {
       ThingEvents.emit(`${event}:${doc._id}`, doc);
       ThingEvents.emit(event, doc);
     };
   }
   
   export function applyHooks(schema) {
   // Register the event emitter to the model events
     for(var e in events) {
       let event = events[e];
       schema.post(e, emitEvent(event));
     }
   }
   
   export default ThingEvents;

   👍React with 👍2Reacted by Eli Krumholz and Andrew Koroluk

   🎉React with 🎉2Reacted by Nigel Fish and nicolasacquaviva
2. ernistkg commented on Feb 5, 2017

   

   ernistkg

   on Feb 5, 2017

   More actions

   I might be wrong in reasons but this solution works.
3. EliKrumholz commented on Feb 5, 2017

   

   EliKrumholz

   on Feb 5, 2017

   Author

   More actions

   Nice work, Ernisto, thanks! I was able to replicate your solution and it fixes the issue on my heroku deployment.

   I think you're correct about Thing.schema.post not working properly in ./server/api/thing/thing.events.js but I actually think this is on the end of Mongoose, rolling back the version to "mongoose": "~4.7.9" in package.json seems to fix this error too, which also means it's probably related to #2479, so rolling back mongoose for now and opening an issue with mongoose is probably the best solution.
4. ernistkg commented on Feb 7, 2017

   

   ernistkg

   on Feb 7, 2017

   More actions

   Thank you!

   I haven't tried older versions. I thought something was broken in angular-fullstack after refactor maybe or something else.
5. Awk34 commented on Feb 7, 2017

   

   Awk34

   on Feb 7, 2017

   Collaborator

   More actions

   Closing as duplicate of #2479
6. Awk34

   closed this as completedon Feb 7, 2017
7. Awk34

   added

   duplicate

   on Feb 7, 2017