Skip to content

Update to ts 2.4, turn on strict mode. - #45

Merged
SethDavenport merged 2 commits into
angular-redux:masterfrom
SethDavenport:chore/typescript-2.4
Jul 9, 2017
Merged

SethDavenport merged 2 commits into
angular-redux:masterfrom
SethDavenport:chore/typescript-2.4

Conversation

@SethDavenport

Copy link
Copy Markdown
Member

No description provided.

action: AnimalAPIAction): IAnimalList {
a: Action): IAnimalList {

const action = a as AnimalAPIAction;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downcast is a workaround for reduxjs/redux#2467

Comment thread src/app/store/reducers.ts Outdated
elephant: createAnimalAPIReducer(ANIMAL_TYPES.ELEPHANT),
lion: createAnimalAPIReducer(ANIMAL_TYPES.LION),
router: routerReducer,
router: routerReducer as Reducer<any>,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is a workaround for angular-redux/router#17

@SethDavenport
SethDavenport merged commit ecb9cf3 into angular-redux:master Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant