Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Incorrect imports in lib/index.ts #5325

Closed

Description

@sandersn
  • Typescript: 3.7, currently available as typescript@3.7.0-beta
  • Protractor Version: master

lib/index.ts incorrectly re-exports two types from plugins.ts:

import {PluginConfig, ProtractorPlugin} from './plugins';
export type PluginConfig = PluginConfig;
export type ProtractorPlugin = ProtractorPlugin;

The references in the type aliases should be circular, but in current versions of Typescript, are not. The correct way to write this is:

export {PluginConfig, ProtractorPlugin} from './plugins';

In Typescript 3.7 the current code will be an error. The beta is available as typescript@3.7.0-beta.

I'll create a PR shortly with the fix.

Activity

  1. esturkce commented on Jan 10, 2020

    @esturkce

    I got the same error, is there a solution yet?
    thanks

  2. userJulienMoreau commented on Apr 14, 2020

    @userJulienMoreau

    I have the same error, for the moment I downgrade for typescript 3.6.4

  3. beh-rouz commented on Apr 19, 2020

    @beh-rouz

    Same issue here, when I updated my angular project from version 8.x.x to 9.x.x and tried to get a production build with ng build -c <config> but eventually found a way to get around it.

    I just removed node_modules, package-lock.json and run npm install.

    $ rm -rf node_modules/ package-lock.json
    $ npm install
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions