Skip to content

Fix agtype integer division overflow - #2591

Open
sean0407 wants to merge 2 commits into
apache:masterfrom
sean0407:codex/age-int64-div-overflow
Open

sean0407 wants to merge 2 commits into
apache:masterfrom
sean0407:codex/age-int64-div-overflow

Conversation

@sean0407

Copy link
Copy Markdown

Summary

  • Return PostgreSQL's bigint range error for INT64_MIN / -1 in agtype integer division.
  • Add a Cypher regression case for the reported expression.

Evidence

Merge Danger

  • Low: the guard affects only the overflowing signed 64-bit integer division pair; other numeric paths are unchanged.

Closes #2590

@MuhammadTahaNaveed

Copy link
Copy Markdown
Member

@sean0407 tests fail

@sean0407

Copy link
Copy Markdown
Author

I corrected the expected regression output in ce6da4f to match the bigint-overflow error shown by the failing CI diff. git diff --check passes; I have not run the PostgreSQL regression suite locally. Could you approve or rerun the regression workflow on this head so we can confirm the output is aligned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integer division by -1 on INT64_MIN raises a misclassified floating-point exception (22P01) instead of bigint out of range

2 participants