Skip to content

Keep Dag list filters when returning through the Dags link - #76953

Merged
choo121600 merged 1 commit into
apache:mainfrom
astronomer:bb/dags-nav-last-query
Nov 16, 2026
Merged

choo121600 merged 1 commit into
apache:mainfrom
astronomer:bb/dags-nav-last-query

Conversation

@bbovenzi

@bbovenzi bbovenzi commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Persist dags list filters by storing the most recently used query params on the dags list in a provider and include them in any /dags link in the UI.

This replaces the approach in #76238, using simple query params instead of a new layer of localStorage logic. No filters will persist across tabs on the same browser.

Filters kept through the nav button and the Dags tab

dags-nav-keeps-filters

related: #76235


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (Opus 5.5) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The Dag list keeps its filters only in the URL, and the Dags button in
the nav and the Dags tab above the list both pointed at a bare /dags.
Opening a Dag, or switching to Dag Runs, and coming back through either
link reset the list to its default view, so users had to rebuild the
filters each time. Browser Back worked; the links didn't.

The list's last query is held in memory above the routes rather than in
localStorage, so each browser tab keeps its own view, a new tab still
opens the plain list, and nothing writes the URL on landing to race the
paused default or a pinned preset. Paging and sort are left behind: they
describe where you were in the list, and sort already falls back to its
stored per-page default.

Co-Authored-By: Claude <noreply@anthropic.com>
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 11, 2026
@bbovenzi bbovenzi changed the title UI: Keep Dag list filters when returning through the Dags link Keep Dag list filters when returning through the Dags link Nov 11, 2026
@bbovenzi bbovenzi added this to the Airflow 3.4.1 milestone Nov 11, 2026
@bbovenzi bbovenzi added the backport-to-v3-4-test Backport to v3-4-test label Nov 11, 2026
@bbovenzi
bbovenzi marked this pull request as ready for review November 11, 2026 21:53

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is much simpler than the localStorage approach 😲

@choo121600
choo121600 merged commit 3d8302a into apache:main Nov 16, 2026
136 of 140 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-4-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ v3-4-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 3d8302a v3-4-test

This should apply the commit to the v3-4-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-4-test Backport to v3-4-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants