Repository navigation
Don't hardcode deferrable mode in Athena Spark system test - #77173
Open
seanghaeli wants to merge 1 commit into
Open
seanghaeli wants to merge 1 commit into
seanghaeli wants to merge 1 commit into
Conversation
The deferrable example task forced deferrable=True, so the Dag hangs when it runs with an executor and no triggerer. Like the other Amazon system tests, keep one calculation task and leave deferrable unset so it follows operators.default_deferrable.
seanghaeli
marked this pull request as ready for review
November 16, 2026 19:41
vincbeck
approved these changes
Nov 16, 2026
vincbeck
enabled auto-merge (squash)
November 16, 2026 21:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #75915. Same fix as #70206 made for the Glue crawler system test.
deferrable=True, and the original task was pinned todeferrable=False.deferrableunset, so it followsoperators.default_deferrablelike the other Amazon system tests. Both modes still get covered by flipping that setting.exampleincludeof the removed snippet. The "Deferrable mode" section still explainsdeferrable=True.Ran the system test against AWS with
default_deferrableset to true (task deferred and resumed) and false (synchronous). Both passed and cleaned up after themselves.