Repository navigation
Report invalid language SDK cron schedules as import errors - #77176
aaron-y-chen wants to merge 2 commits into
Conversation
|
Fork CI: green. CI for the latest commit passed in your fork. The pull request is ready for maintainer review. Pull requests from contributors run their CI in the contributor's own fork. GitHub Actions is free and has no minute limit on public forks, while the CI capacity of the Apache Software Foundation is shared by every ASF project and is finite. Fork CI tested this branch merged with Latest run: https://github.com/aaron-y-chen/airflow/actions/runs/43970410672 How this works: CI in your fork. This comment was posted automatically by the fork CI monitor from templates drafted with an AI-assisted tool, so it may contain mistakes. An Apache Airflow maintainer, a real person, will review the pull request once its fork CI is green. Why the first pass is automated. |
…invalid cron handling
Problem
Go/Java SDKs check cron shape but leave range validation to core. Unlike Python Dag parsing, language SDK parsing omitted
timetable.validate(), so0 24 * * *was accepted without an import error and could not be scheduled.Reproduction
On main branch, apply only the new regression test, without the production fix, and run the command below. The fake runtime returns an invalid-cron Dag alongside a valid daily Dag; both
CronTriggerTimetableandCronDataIntervalTimetablecases fail because the invalid Dag remains accepted.Fix
Call
deserialized.timetable.validate()in the language SDK processor to reuse core's validator. Existing error handling records an import error and excludes the invalid Dag while preserving valid Dags in the same result.Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex (GPT-6) following the guidelines