Skip to content

Raise ValueError for conflicting Trino authentication methods - #77180

Open
eranhermush wants to merge 1 commit into
apache:mainfrom
eranhermush:trino-hook-value-error
Open

eranhermush wants to merge 1 commit into
apache:mainfrom
eranhermush:trino-hook-value-error

Conversation

@eranhermush

Copy link
Copy Markdown

TrinoHook.get_conn() raised the generic AirflowException when a connection configures more than one authentication method. That is an invalid connection setting, so it now raises ValueError, in line with the ongoing effort to replace direct AirflowException raises with specific exceptions. The generated/known_airflow_exceptions.txt allowlist entry for the hook is removed accordingly.

Checks run locally:

  • uv run --project providers/trino pytest providers/trino/tests/unit/trino/hooks/test_trino.py: 42 passed
  • test_get_conn_invalid_auth fails without the hook change and passes with it
  • prek pre-commit hooks on the changed files pass (Breeze-based hooks were skipped as Breeze is not installed locally)

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5.5)

Generated-by: Claude Code (Opus 5.5) following the guidelines

Configuring more than one authentication method on a Trino connection is an
invalid connection setting, so it should surface as a ValueError rather than
the generic AirflowException that the project is phasing out.
@boring-cyborg

boring-cyborg Bot commented Nov 16, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant