Repository navigation
Raise ValueError for conflicting Trino authentication methods - #77180
Open
eranhermush wants to merge 1 commit into
Open
eranhermush wants to merge 1 commit into
eranhermush wants to merge 1 commit into
Conversation
Configuring more than one authentication method on a Trino connection is an invalid connection setting, so it should surface as a ValueError rather than the generic AirflowException that the project is phasing out.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrinoHook.get_conn()raised the genericAirflowExceptionwhen a connection configures more than one authentication method. That is an invalid connection setting, so it now raisesValueError, in line with the ongoing effort to replace directAirflowExceptionraises with specific exceptions. Thegenerated/known_airflow_exceptions.txtallowlist entry for the hook is removed accordingly.Checks run locally:
uv run --project providers/trino pytest providers/trino/tests/unit/trino/hooks/test_trino.py: 42 passedtest_get_conn_invalid_authfails without the hook change and passes with itprekpre-commit hooks on the changed files pass (Breeze-based hooks were skipped as Breeze is not installed locally)Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines