Repository navigation
GH-55275: [C++][FlightRPC][ODBC] Unset CPACK_WIX_PRODUCT_GUID to allow Windows installer upgrade - #55276
Draft
alinaliBQ wants to merge 1 commit into
Draft
GH-55275: [C++][FlightRPC][ODBC] Unset CPACK_WIX_PRODUCT_GUID to allow Windows installer upgrade#55276alinaliBQ wants to merge 1 commit into
CPACK_WIX_PRODUCT_GUID to allow Windows installer upgrade#55276alinaliBQ wants to merge 1 commit into
Conversation
github-actions
Bot
added
Component: C++
Component: FlightRPC
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-55275
https://cmake.org/cmake/help/v4.5/cpack_gen/wix.html#variable:CPACK_WIX_PRODUCT_GUID
Highlights my own.
What changes are included in this PR?
Removed hard-coded
CPACK_WIX_PRODUCT_GUID. Then CPack will generate the UUID value for Product ID during each build, and it should unblock users from upgrading using ODBC installer.Are these changes tested?
Regression tested in CI.
Are there any user-facing changes?
no
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
CPACK_WIX_PRODUCT_GUIDfor ODBC windows installer #55275