Skip to content

ARTEMIS-6353 perf client and perf consumer --tx never commit: the session is transacted, but each message is only acknowledged - #6870

Merged
clebertsuconic merged 1 commit into
apache:mainfrom
grepjava:ARTEMIS-6353
Nov 6, 2026
Merged

clebertsuconic merged 1 commit into
apache:mainfrom
grepjava:ARTEMIS-6353

Conversation

@grepjava

@grepjava grepjava commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

With --tx the consumers' sessions are transacted, but each message is only acknowledged, which does nothing in a transacted session, and nothing commits. The run measures no consumer transactions and leaves every message on the queue, and once the backlog pages, dispatch blocks on the unacknowledged messages (AMQ224127) and the run never ends.

The consumers now commit every --commit-interval messages, or every message without it. What is left is committed when the benchmark closes, with the connections stopped first as a session has one thread of control. The --tx descriptions say so.

--tx runs now pay for the commits and really consume the messages, so their numbers are not comparable with those of earlier versions.

RecordingMessageListenerTest checks the commits per interval, per message, on close, without a transaction, and that a failed commit is fatal. The four that expect a commit or a failure fail without the fix.

Tested against a broker built from this branch:

  • perf client --persistent --tx --commit-interval 100 --duration 60 --warmup 15: ended, 1480401 messages added and acknowledged, none left on the queue.
  • 1050 messages consumed with perf consumer --tx --commit-interval 100 --message-count 1050: the queue went from 1050 to 0, so the last 50 were committed on close.
  • perf client --persistent --tx --duration 12 --warmup 2: ended, 174498 acknowledged, none left.

https://issues.apache.org/jira/browse/ARTEMIS-6353

…sion is transacted, but each message is only acknowledged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants