Repository navigation
ARTEMIS-6353 perf client and perf consumer --tx never commit: the session is transacted, but each message is only acknowledged - #6870
Merged
Conversation
…sion is transacted, but each message is only acknowledged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--txthe consumers' sessions are transacted, but each message is only acknowledged, which does nothing in a transacted session, and nothing commits. The run measures no consumer transactions and leaves every message on the queue, and once the backlog pages, dispatch blocks on the unacknowledged messages (AMQ224127) and the run never ends.The consumers now commit every
--commit-intervalmessages, or every message without it. What is left is committed when the benchmark closes, with the connections stopped first as a session has one thread of control. The--txdescriptions say so.--txruns now pay for the commits and really consume the messages, so their numbers are not comparable with those of earlier versions.RecordingMessageListenerTestchecks the commits per interval, per message, on close, without a transaction, and that a failed commit is fatal. The four that expect a commit or a failure fail without the fix.Tested against a broker built from this branch:
perf client --persistent --tx --commit-interval 100 --duration 60 --warmup 15: ended, 1480401 messages added and acknowledged, none left on the queue.perf consumer --tx --commit-interval 100 --message-count 1050: the queue went from 1050 to 0, so the last 50 were committed on close.perf client --persistent --tx --duration 12 --warmup 2: ended, 174498 acknowledged, none left.https://issues.apache.org/jira/browse/ARTEMIS-6353