Repository navigation
Add monitor of timer thread task - #3603
Conversation
6812c64 to
62dc91f
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open findings
Latency measurement + recorder update is now executed for every task run, even when… · New The exposed bvar name\"task\"is very generic and may be ambiguous/collision-prone under a… · New New in-class initializers useNULLfor pointer and function-pointer fields. In C++11+ code,… · New Therun_and_deletecomment/doc no longer matches the signature/behavior now that it records into… · New
What changed in this PR
Adds per-task latency monitoring to TimerThread and updates ignore rules for Bazel lockfiles.
Changes:
- Instrument
TimerThread::Taskexecution time with abvar::LatencyRecorderand expose it under the configured bvar prefix. - Switch
Taskmembers to in-class initialization and adjustrun_and_deletesignature to accept the latency recorder. - Ignore
MODULE.bazel.lockin.gitignore.
| File | Description |
|---|---|
| src/bthread/timer_thread.cpp | Adds task latency recording/exposure and updates Task initialization + API to pass the recorder. |
| .gitignore | Adds Bazel module lockfile to ignored files. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
62dc91f to
024562d
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open findings
4 resolved since last review
The exposed bvar name\"task\"is very generic and may be ambiguous/collision-prone under a… Latency measurement + recorder update is now executed for every task run, even when… Therun_and_deletecomment/doc no longer matches the signature/behavior now that it records into… New in-class initializers useNULLfor pointer and function-pointer fields. In C++11+ code,…
🧠 Review effort: Lite
|
I believe this PR is ready for a final human review. I’ve evaluated the Copilot feedback and fixed the confirmed issues. @wwbmmm PTAL. |


What problem does this PR solve?
Issue Number: resolve
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: