Repository navigation
Fix flaky Prometheus metrics startup test - #3610
Merged
chenBright merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
PrometheusMetrics.sanitywaits for asynchronous server method metrics to beexposed after
Server::Start().The test used a fixed number of
bthread_usleep()calls. Sincebthread_usleep()may return early when interrupted, the loop can finish in afew milliseconds instead of waiting for its intended five seconds. This makes
the test flaky when
UpdateDerivedVarshas not yet exposed the method bvars.What is changed and the side effects?
Changed:
butil::cpuwide_time_us().Side effects:
Performance effects:
None. This only affects a unit test.
Breaking backward compatibility:
None.
Check List:
brpc_prometheus_metrics_unittestPrometheusMetrics.sanity