Repository navigation
[CALCITE-7820] nonReservedKeywordsToRemove in parser config.fmpp is documented but never consumed by Parser.jj - #5358
Open
dajiaohuang wants to merge 1 commit into
Conversation
…ocumented but never consumed by Parser.jj Filter the combined non-reserved keyword list before splitting it into three grammar productions. Test reserved-word metadata, unquoted rejection, quoted acceptance and an unchanged non-reserved keyword. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7820
Changes Proposed
Setting
nonReservedKeywordsToRemove: ["ADD"]currently leavesADDusable as an unquoted identifier, contrary to the documented parser configuration contract.Filter the combined base and added non-reserved keyword list before splitting it into the three grammar productions. This makes removal take effect while preserving the existing configuration fallbacks and partitioning.
The generated extension-parser regression checks reserved-word metadata, rejection of unquoted
ADD,AFTER, andBEFORE, acceptance of their quoted forms, and continued acceptance of the unaffectedKEYidentifier.Validation:
ADDis not reserved).:core:test --tests '*ExtensionSqlParserTest': successful, 520 tests, 0 failures, 3 skipped../gradlew build: successful, 413 tasks, with no test exclusions added. Local fixture tests used the default configuration; optional external integrations were not enabled.AI assistance: OpenAI Codex helped implement and validate this change.