Repository navigation
[CALCITE-7927] Preserve nested casts around dynamic parameters - #5402
Open
atharvrastogi1411 wants to merge 1 commit into
Open
atharvrastogi1411 wants to merge 1 commit into
atharvrastogi1411 wants to merge 1 commit into
Conversation
Contributor
|
What is the semantics of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CALCITE-7927.
Extend the dynamic-parameter protection introduced by CALCITE-6346 to both nested-cast elimination paths in
RexSimplify.simplifyCast: removing both casts and removing only the inner cast. Neither shortcut should discard a cast based solely on a dynamic parameter's declared type.For example, the JDBC adapter currently simplifies:
to:
With
"longer-value"bound usingsetString, the original expression returns"l"in HSQLDB, but the simplified JDBC query returns"longer-value". Preserving the nested casts restores the correct result. CALCITE-7118's Java executor parameter conversion does not protect JDBC pushdown.Tests
testDynamicParameterDoubleCastgolden to retain its innerINTEGERcast.Validation passed: 1,050 tests discovered, 0 failures, 4 skipped; both core Checkstyle tasks passed.
The full multi-module build was not run.