Skip to content

[CALCITE-7940] AssertionError when selecting a common column of three tables joined with USING - #5419

Open
snuyanzin wants to merge 1 commit into
apache:mainfrom
snuyanzin:calcite7940
Open

snuyanzin wants to merge 1 commit into
apache:mainfrom
snuyanzin:calcite7940

Conversation

@snuyanzin

Copy link
Copy Markdown
Contributor

Jira Link

CALCITE-7940

Changes Proposed

The PR allows having common column while several tables join with USING

@sonarqubecloud

Copy link
Copy Markdown

@mihaibudiu mihaibudiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, my comments are rather cosmetic

!ok

# [CALCITE-7940] AssertionError when selecting a common column of three tables joined with USING.
select deptno, count(*) as c

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment describing how these results were validated

}
}

/** Returns the column {@code name} of the left or right input of a join. */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would document the parameters; "left" could be interpreted as "left join" for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants