Allow domain admin to change domain and account settings by davidjumani · Pull Request #4339 · apache/cloudstack

davidjumani · 2020-09-23T05:15:01Z

Description

Allow domain admin to change domain and account settings

Fixes #3752 && #5494

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

yadvr · 2021-06-17T07:39:07Z

Ping @davidjumani here?

davidjumani · 2021-06-18T06:35:43Z

@rhtyd Will test and mark as ready

nvazquez · 2021-09-07T17:56:48Z

@davidjumani is this PR still in progress?

sureshanaparti · 2021-09-20T04:56:29Z

@davidjumani is this PR ready for review? can you fix the conflicts please.

…in-config

davidjumani · 2021-09-21T11:07:49Z

@sureshanaparti It's ready :D

davidjumani · 2021-09-21T11:11:09Z

  title: 'label.configuration',
  icon: 'setting',
-  permission: ['listConfigurations'],
+  permission: ['listConfigurations', 'listInfrastructure'],


Adding this so the global settings tab doesn't show to domain admins since they now have access to listConfigurations

…in-config

davidjumani · 2022-02-08T05:33:44Z

@blueorangutan package

blueorangutan · 2022-02-08T05:34:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-08T06:38:51Z

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 2508

davidjumani · 2022-02-08T07:38:56Z

@blueorangutan test

blueorangutan · 2022-02-08T07:40:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-08T16:55:16Z

Trillian test result (tid-3223)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4339-t3223-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

…in-config

davidjumani · 2022-02-15T12:28:51Z

@blueorangutan package

blueorangutan · 2022-02-15T12:30:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T13:28:03Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2616

nvazquez · 2022-02-15T13:32:06Z

@blueorangutan test

blueorangutan · 2022-02-15T13:33:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2022-02-18T02:44:18Z

@blueorangutan package

blueorangutan · 2022-02-18T02:45:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-18T03:48:30Z

Packaging result: ✔️ el7 ✖️ el8 ✔️ debian ✔️ suse15. SL-JID 2649

DaanHoogland · 2022-02-18T10:29:10Z

@blueorangutan test

blueorangutan · 2022-02-18T10:30:05Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-18T21:40:35Z

Trillian test result (tid-3388)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38854 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4339-t3388-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2022-02-21T08:53:50Z

All travis jobs failed. seems to be a systemvm issue !?!

nvazquez · 2022-02-21T15:25:35Z

All green now, merging

davidjumani force-pushed the allow-domadmin-config branch 2 times, most recently from d3f5617 to e6b202c Compare September 25, 2020 09:49

yadvr added this to the 4.16.0.0 milestone Sep 25, 2020

ACSGitBot added status:wip type:enhancement labels Nov 3, 2020

davidjumani force-pushed the allow-domadmin-config branch 4 times, most recently from 33eb762 to 542392c Compare June 22, 2021 10:52

Allow domain admin to change domain and account settings

679cb20

davidjumani force-pushed the allow-domadmin-config branch from 542392c to 679cb20 Compare June 22, 2021 10:54

davidjumani marked this pull request as ready for review July 1, 2021 07:12

davidjumani marked this pull request as draft July 1, 2021 07:12

sureshanaparti closed this Sep 20, 2021

sureshanaparti reopened this Sep 20, 2021

Pearl1594 mentioned this pull request Sep 21, 2021

Domain settings not visible to domain admin #3752

Closed

davidjumani added 2 commits September 21, 2021 15:11

Merge branch 'main' of github.com:apache/cloudstack into allow-domadm…

b1e081f

…in-config

Cleanup

a413b9d

davidjumani force-pushed the allow-domadmin-config branch 3 times, most recently from 27efa32 to 9a49951 Compare September 21, 2021 11:03

Remove useless global setting

5c6075c

davidjumani force-pushed the allow-domadmin-config branch from 9a49951 to 5c6075c Compare September 21, 2021 11:07

davidjumani marked this pull request as ready for review September 21, 2021 11:07

davidjumani commented Sep 21, 2021

View reviewed changes

nvazquez linked an issue Feb 7, 2022 that may be closed by this pull request

Normal users with granted permission on listconfigurations/updateconfiguration are able to list and update global configurations #5494

Closed

Merge branch 'main' of github.com:apache/cloudstack into allow-domadm…

854980d

…in-config

davidjumani added 2 commits February 15, 2022 17:07

Merge branch 'main' of github.com:apache/cloudstack into allow-domadm…

630d98f

…in-config

Moving upgrade path

6bbbcc3

apache deleted a comment from blueorangutan Feb 15, 2022

DaanHoogland closed this Feb 21, 2022

DaanHoogland reopened this Feb 21, 2022

nvazquez merged commit 2a1a012 into apache:main Feb 21, 2022

weizhouapache mentioned this pull request Mar 17, 2022

server: add account-level setting: router.hypervisor.type #6101

Closed

1 of 12 tasks

soreana mentioned this pull request Feb 28, 2023

Global setting to disallow domain admin to change domain and account settings #7296

Open

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

davidjumani commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

How Has This Been Tested?

Uh oh!

yadvr commented Jun 17, 2021

Uh oh!

davidjumani commented Jun 18, 2021

Uh oh!

nvazquez commented Sep 7, 2021

Uh oh!

sureshanaparti commented Sep 20, 2021

Uh oh!

davidjumani commented Sep 21, 2021

Uh oh!

davidjumani Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

davidjumani commented Feb 8, 2022

Uh oh!

blueorangutan commented Feb 8, 2022

Uh oh!

blueorangutan commented Feb 8, 2022

Uh oh!

davidjumani commented Feb 8, 2022

Uh oh!

blueorangutan commented Feb 8, 2022

Uh oh!

blueorangutan commented Feb 8, 2022

Uh oh!

davidjumani commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

nvazquez commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

nvazquez commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

DaanHoogland commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

DaanHoogland commented Feb 21, 2022

Uh oh!

nvazquez commented Feb 21, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

davidjumani commented Sep 23, 2020 •

edited

Loading