Repository navigation
Conversation
The RandomStringGenerator constructor kept a reference to the Builder's predicate set rather than a copy. Builder.filteredBy(...) clears and refills that set, so calling it again on the same Builder silently changed the filters of every generator already built from it. The character list is already copied in the same constructor; copy the predicates as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RandomStringGeneratorkeeps a reference to theBuilder's filter set instead of copying it, andBuilder.filteredBy(...)clears and refills that same set. So reusing a builder quietly changes generators that were already built from it:For a password or token generator that is a silent drop in entropy (12 characters go from roughly 71 bits to 40). It also means a generator documented as thread-safe iterates a set the builder can still modify. The character list is already copied in the same constructor, so the predicates are now copied the same way.
testChangeOfFilterAfterGetfails without the main change (expected: <a> but was: <b>) and passes with it. The defaultmvnbuild is green locally on Java 21 (1990 tests, Checkstyle, PMD, SpotBugs, japicmp and Javadoc).mvn; that'smvnon the command line by itself.