Skip to content

bug: Comet crashes on DataFrame API #2813

Closed

Description

@comphead

Describe the bug

Faced this bug in #2793 (comment)

Spark works fine

+------+------+
|c1    |result|
+------+------+
|123456|NULL  |
|12    |12    |
+------+------+

Steps to reproduce

Run the test

test("make decimal") {

    sql("create table t1 using parquet as select 123456 as c1 from range(1)")

    withSQLConf(
      CometConf.COMET_EXEC_ENABLED.key -> "true",
      SQLConf.USE_V1_SOURCE_LIST.key -> "parquet",
      CometConf.COMET_ENABLED.key -> "true",
      CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "true",
      "spark.sql.ansi.enabled" -> "true",
      "spark.sql.adaptive.enabled" -> "false",
      "spark.comet.expression.Sum.allowIncompatible" -> "true",
      CometConf.COMET_NATIVE_SCAN_IMPL.key -> "native_iceberg_compat",
      "spark.sql.optimizer.excludedRules" -> "org.apache.spark.sql.catalyst.optimizer.ConstantFolding") {

      val df = sql("select * from t1")
      val makeDecimalExpr = MakeDecimal(df.col("c1").expr, 3, 0)
      val makeDecimalColumn = new Column(makeDecimalExpr)
      val df1 = df.withColumn("result", makeDecimalColumn)
      df1.explain("formatted")

      checkSparkAnswerAndOperator(df1)
    }

  }

The Comet crashes with

Caused by: org.apache.comet.CometNativeException: primitive array
        at std::backtrace::Backtrace::create(__internal__:0)
        at comet::errors::init::{{closure}}(__internal__:0)
        at std::panicking::panic_with_hook(__internal__:0)
        at std::panicking::panic_handler::{{closure}}(__internal__:0)
        at std::sys::backtrace::__rust_end_short_backtrace(__internal__:0)
        at __rustc::rust_begin_unwind(__internal__:0)
        at core::panicking::panic_fmt(__internal__:0)
        at core::option::expect_failed(__internal__:0)
        at datafusion_comet_spark_expr::math_funcs::internal::make_decimal::spark_make_decimal(__internal__:0)
        at <datafusion_comet_spark_expr::comet_scalar_funcs::CometScalarFunction as datafusion_expr::udf::ScalarUDFImpl>::invoke_with_args(__internal__:0)
        at <datafusion_physical_expr::scalar_function::ScalarFunctionExpr as datafusion_physical_expr_common::physical_expr::PhysicalExpr>::evaluate(__internal__:0)
        at <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next(__internal__:0)
        at <datafusion_physical_plan::projection::ProjectionStream as futures_core::stream::Stream>::poll_next(__internal__:0)
        at comet::execution::jni_api::Java_org_apache_comet_Native_executePlan::{{closure}}::{{closure}}(__internal__:0)
        at _Java_org_apache_comet_Native_executePlan(__internal__:0)
	at org.apache.comet.Native.executePlan(Native Method)

Expected behavior

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions